Code question (canohost.c)

[John Devitofranceschi]

Oh, I agree that it should not take such a long time to twig that "0" is not
a service name, but Openstep can through a few NetInfo layers and through an
NIS services map before it gets to that point. :) 

jd

-----Original Message-----
From: openssh-unix-dev-bounces+jdvf=optonline.net at mindrot.org
[mailto:openssh-unix-dev-bounces+jdvf=optonline.net at mindrot.org] On Behalf
Of Damien Miller
Sent: Thursday, April 29, 2004 9:54 PM
To: Ben Lindstrom
Cc: openssh-unix-dev at mindrot.org; John Devitofranceschi
Subject: Re: Code question (canohost.c)


Ben Lindstrom wrote:

> 
> 
> On Thu, 29 Apr 2004, John Devitofranceschi wrote:
> 
> 
>>So, I looked at some older versions of the code and found that, 
>>indeed, a NULL was sent as the second parameter in previous releases.
>>
> The code never existed before this patch was added.
> 
> http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/canohost.c.diff?
> r1=1.36&r2=1.37

I think the use of "0" instead of NULL is wrong, but I'm not sure. I'll take
a look over the weekend.

Then again, getservbyname("0") taking time is wrong too :)

-d

_______________________________________________
openssh-unix-dev mailing list
openssh-unix-dev at mindrot.org
http://www.mindrot.org/mailman/listinfo/openssh-unix-dev