ebcdic problem in bufaux.c

Damien Miller djm at mindrot.org
Fri Jul 23 08:02:34 EST 2004


Greg Lambert wrote:
> I am working on a port of Openssh 3.8p1 after already
> having done a port of Openssh 3.5p1.  There are a
> couple of new lines in buffer_get_bignum2() that are
> causing me problems:
> 
>         if (len > 0 && (bin[0] & 0x80))
>                 fatal("buffer_get_bignum2: negative
> numbers not supported");
> 
> The "& 0x80" check is not relevant in ebcdic.  

Why not? The contents of a bignum are binary, not text.

> Does anyone know why this check was added?
> What are the consequences of removing it?

These should be obvious from the error message.

-d




More information about the openssh-unix-dev mailing list