Call for testing: OpenSSH-5.7

Tim Rice tim at multitalents.net
Sat Jan 15 08:44:38 EST 2011


On Fri, 14 Jan 2011, Ángel González wrote:

> Is that the prefered way for creating the configure?
> I get a lot of "AC_LANG_CONFTEST: no AC_LANG_SOURCE call detected in
> body" warnings with autoconf 2.68
> 
> $ autoreconf --version
> autoreconf (GNU Autoconf) 2.68
> 
> That warning was added in autoconf 2.68, because failing to provide
> AC_LANG_SOURCE
> could result in a "broken configure" [1].
> 
> [1] http://www.mail-archive.com/bug-autoconf@gnu.org/msg03052.html

As Damien mentioned in another post, we use autoconf 2.61.
That said, we could be consistant on the use of AC_LANG_SOURCE.
Does this patch make your 2.68 happy?
----------
--- configure.ac.old	2011-01-11 21:17:45.210746003 -0800
+++ configure.ac	2011-01-14 13:33:54.295871066 -0800
@@ -23,7 +23,7 @@
 	AC_MSG_CHECKING([if $CC supports $1])
 	saved_CFLAGS="$CFLAGS"
 	CFLAGS="$CFLAGS $1"
-	AC_COMPILE_IFELSE([void main(void) { return 0; }],
+	AC_COMPILE_IFELSE([AC_LANG_SOURCE([[void main(void) { return 0; }]])],
 		[ AC_MSG_RESULT(yes) ],
 		[ AC_MSG_RESULT(no)
 		  CFLAGS="$saved_CFLAGS" ]
@@ -1953,11 +1953,11 @@
 
 if test "x$check_for_conflicting_getspnam" = "x1"; then
 	AC_MSG_CHECKING(for conflicting getspnam in shadow.h)
-	AC_COMPILE_IFELSE(
+	AC_COMPILE_IFELSE([AC_LANG_SOURCE([
 		[
 #include <shadow.h>
 int main(void) {exit(0);}
-		],
+		]])],
 		[
 			AC_MSG_RESULT(no)
 		],
@@ -3214,7 +3217,7 @@
 dnl make sure we're using the real structure members and not defines
 AC_CACHE_CHECK([for msg_accrights field in struct msghdr],
 		ac_cv_have_accrights_in_msghdr, [
-	AC_COMPILE_IFELSE(
+	AC_COMPILE_IFELSE([AC_LANG_SOURCE([
 		[
 #include <sys/types.h>
 #include <sys/socket.h>
@@ -3228,7 +3231,7 @@
 m.msg_accrights = 0;
 exit(0);
 }
-		],
+		]])],
 		[ ac_cv_have_accrights_in_msghdr="yes" ],
 		[ ac_cv_have_accrights_in_msghdr="no" ]
 	)
@@ -3277,7 +3280,7 @@
 
 AC_CACHE_CHECK([for msg_control field in struct msghdr],
 		ac_cv_have_control_in_msghdr, [
-	AC_COMPILE_IFELSE(
+	AC_COMPILE_IFELSE([AC_LANG_SOURCE([
 		[
 #include <sys/types.h>
 #include <sys/socket.h>
@@ -3291,7 +3294,7 @@
 m.msg_control = 0;
 exit(0);
 }
-		],
+		]])],
 		[ ac_cv_have_control_in_msghdr="yes" ],
 		[ ac_cv_have_control_in_msghdr="no" ]
 	)
----------

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net


More information about the openssh-unix-dev mailing list