Call for testing: OpenSSH 6.8

[Tom G. Christensen]

On 28/02/15 00:53, Damien Miller wrote:
> On Sat, 28 Feb 2015, Tom G. Christensen wrote:
>> Only one little nit prevents 'all tests passed':
>> gmake[1]: Entering directory
>> `/export/home/tgc/buildpkg/openssh/src/openssh-git/regress'
>> test "x" != "x" && mkdir -p
>> /export/home/tgc/buildpkg/openssh/src/openssh-git/regress//valgrind-out
>> gmake[1]: *** [prep] Error 1
>>
>> Reversing the test to = and || instead will fix it.
>
> committed - thanks for persisting with the tests.
>

Perhaps I should have been more clear but the above error is from the 
'prep' target while it looks like you changed the 'unit' target instead.

I propose this patch to avoid the error:

diff --git a/regress/Makefile b/regress/Makefile
index 860c53f..1eef340 100644
--- a/regress/Makefile
+++ b/regress/Makefile
@@ -7,7 +7,7 @@ tests:          prep $(REGRESS_TARGETS)
  interop interop-tests: t-exec-interop

  prep:
-       test "x${USE_VALGRIND}" != "x" && mkdir -p $(OBJ)/valgrind-out
+       test "x${USE_VALGRIND}" = "x" || mkdir -p $(OBJ)/valgrind-out

  clean:
         for F in $(CLEANFILES); do rm -f $(OBJ)$$F; done


-tgc