Call for testing: OpenSSH 7.3

[Hisashi T Fujinaka]

I think I forgot to send this to the mailing list too.

On Sat, 23 Jul 2016, Damien Miller wrote:

  On Fri, 22 Jul 2016, Hisashi T Fujinaka wrote:

> In NetBSD-current(ish):
> 
> test_sshkey: ..................................[1]   Segmentation fault 
> (core
> dumped) ${V} /home/htodd...
> *** Error code 139
> 
> And gdb bt shows:
> 
> Program terminated with signal SIGSEGV, Segmentation fault.
> #0  0x000000000041174e in cert_parse (key=0x756584f120c0,
> certbuf=0x756584f16200, b=0x756584f161b0) at sshkey.c:1896
> 1896                    key->cert->principals[key->cert->nprincipals++] =
> principal;

  Thanks for reporting this. I don't understand how it could fail at that
  point. Could you rerun the failing test and see what the values of
  key, *key, key->cert and *key->cert are? It's possible to run just the
  sshkey unit test using:

  ./regress/unittests/sshkey/test_sshkey -d regress/unittests/sshkey/testdata

  from the top-level directory.

Program terminated with signal SIGSEGV, Segmentation fault.
#0  0x000000000041174e in cert_parse (key=0x7037f9b120c0, 
certbuf=0x7037f9b16200, b=0x7037f9b161b0) at sshkey.c:1896
1896                    key->cert->principals[key->cert->nprincipals++] = 
principal;
(gdb) bt
#0  0x000000000041174e in cert_parse (key=0x7037f9b120c0, 
certbuf=0x7037f9b16200, b=0x7037f9b161b0) at sshkey.c:1896
#1  sshkey_from_blob_internal (b=b at entry=0x7037f9b161b0, 
keyp=keyp at entry=0x7f7fff104970, allow_cert=allow_cert at entry=1)
    at sshkey.c:2117
#2  0x0000000000411951 in sshkey_from_blob (blob=<optimized out>, 
blen=blen at entry=422, keyp=keyp at entry=0x7f7fff104970)
    at sshkey.c:2150
#3  0x0000000000411a97 in sshkey_read (ret=ret at entry=0x7037f9b12080, 
cpp=cpp at entry=0x7f7fff1049d0) at sshkey.c:1302
#4  0x0000000000414baa in sshkey_try_load_public (k=k at entry=0x7037f9b12080,
    filename=0x7037f9b16070 
"/home/htodd/openssh-portable/regress/unittests/sshkey/testdata/rsa_1-cert.pub",
    commentp=commentp at entry=0x0) at authfile.c:319
#5  0x0000000000415309 in sshkey_load_cert (filename=<optimized out>, 
keyp=keyp at entry=0x7f7fff108a80) at authfile.c:425
#6  0x0000000000409f41 in sshkey_tests () at 
regress/unittests/sshkey/test_sshkey.c:527
#7  0x0000000000405dc3 in tests () at regress/unittests/sshkey/tests.c:24
#8  0x000000000042a2e1 in main (argc=3, argv=0x7f7fff108b68) at 
regress/unittests/test_helper/test_helper.c:162
(gdb) p key
$1 = (struct sshkey *) 0x7037f9b120c0
(gdb) p key->cert
$2 = (struct sshkey_cert *) 0x7037f9b1b080
(gdb) p *key->cert
$3 = {certblob = 0x7037f9b162a0, type = 2, serial = 5, key_id = 
0x7037f9b18090 "julius", nprincipals = 1,
  principals = 0xfffffffff9b180a0, valid_after = 915145200, valid_before = 
1293836400, critical = 0x7037f9b162f0,
  extensions = 0x7037f9b16340, signature_key = 0x0}



-- 
Hisashi T Fujinaka - htodd at twofifty.com
BSEE + BSChem + BAEnglish + MSCS + $2.50 = coffee