Call for testing: OpenSSH 7.6

[Zev Weiss]

On Fri, Sep 22, 2017 at 07:28:01AM CDT, Darren Tucker wrote:
>On Thu, Sep 21, 2017 at 02:22:10AM -0500, Zev Weiss wrote:
>>  test_kex:  regress/unittests/kex/test_kex.c:91 test #1 "sshkey_generate"
>>  ASSERT_INT_EQ(sshkey_generate(keytype, bits, &private), 0) failed:
>>  sshkey_generate(keytype, bits, &private) = -56
>
>That error code is:
>$ grep -- -56 ssherr.h
>#define SSH_ERR_KEY_LENGTH			-56
>
>Unfortunately there's lots of places in that code that can return that.
>I have seen that on one Cygwin system (OpenSSL 1.0.2k) here so I added
>the below code to try to narrow it down.  On mine it gave:
>
>test_kex: dsa_generate_private_key bits 2048 expected 1024
>
>but I don't understand how.
>
>Don't try to use ssh or sshd with this diff as it'll probably mess
>things up pretty good.
>

And now I'm not able to reproduce the failure at all, with or without 
that patch.  Not sure what could possibly be different (same git commit, 
same terminal session/environment, same 'make' command), but repeated 
attempts have been fruitless -- now test_kex gets "352 tests ok" every 
time (after printing a bunch of ENOENT warnings on 
/usr/local/etc/moduli).


Zev