[PATCH] ssh: Add missing openssl-compat.h where needed

Rosen Penev rosenp at gmail.com
Tue Oct 23 09:51:13 AEDT 2018


On Mon, Oct 22, 2018 at 2:13 AM Darren Tucker <dtucker at dtucker.net> wrote:
>
> On 22 October 2018 at 14:39, Rosen Penev <rosenp at gmail.com> wrote:
>>
>> OpenSSL_add_all_algorithms has been deprecated with 1.1. Compatibility
>> is needed.
>
>
> Applied, thanks (master and the 7.9 branch) and will be in the next release.
Thanks.

Embarrassingly, this is not the patch I meant to send. That is, this
patch is incomplete.

If engine support for OpenSSL is enabled, OpenSSL_add_all_algorithms
gets converted to the ssh_ equivalent, which itself uses that
function.

I don't compile in engine or deprecated API support, making the whole
thing fail. I don't know what the proper solution is in the context of
OpenSSH. I just #ifdef it all out.
>
> --
> Darren Tucker (dtucker at dtucker.net)
> GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
>     Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.


More information about the openssh-unix-dev mailing list