Call for testing: OpenSSH 8.0

[Tom G. Christensen]

On 27/03/19 12:00, Damien Miller wrote:
> Hi,
> 
> OpenSSH 8.0p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible.
> 
> Snapshot releases for portable OpenSSH are available from
> http://www.mindrot.org/openssh_snap/
> 

It fails to build on Solaris < 10.

Here's how it looks on Solaris 2.6/x86:
gcc -D__EXTENSIONS__ -D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED=1 -g -O2 
-pipe -Wall -Wpointer-arith -Wuninitialized -Wsign-compare 
-Wformat-security -Wno-pointer-sign -fno-strict-aliasing 
-D_FORTIFY_SOURCE=2 -ftrapv -fno-builtin-memset -fstack-protector-all 
-I. -I.. -I. -I./.. -I/usr/tgcware/include -DHAVE_CONFIG_H -c bsd-misc.c
bsd-misc.c: In function 'utimensat':
bsd-misc.c:132: warning: unused variable 'oflags'
bsd-misc.c:132: warning: unused variable 'ret'
bsd-misc.c: In function 'fchownat':
bsd-misc.c:176: error: 'O_NOFOLLOW' undeclared (first use in this function)
bsd-misc.c:176: error: (Each undeclared identifier is reported only once
bsd-misc.c:176: error: for each function it appears in.)
bsd-misc.c: In function 'fchmodat':
bsd-misc.c:205: error: 'O_NOFOLLOW' undeclared (first use in this function)
gmake[1]: *** [bsd-misc.o] Error 1

To allow the build to finish I added this workaround:
#ifndef O_NOFOLLOW
# define O_NOFOLLOW 0
#endif

I've run the testsuite on Solaris 2.6/x86 and Solaris 9/sparc and all 
tests pass for both.

-tgc