[openssh-commits] [openssh] 02/02: upstream: hostname is not specified by POSIX but uname -n is, so use

[Darren Tucker]

On Mon, 8 Feb 2021 at 09:53, Bob Proulx <bob at proulx.com> wrote:
[...]
> I'll just note that on Debian, Ubuntu, other derivatives (such as
> Mint, Trisquel...) both the "uname -n" and "hostname" values would
> typically be just the short name.  It's not just UnixWare...

Double sigh.

Fortunately for this purpose it only matters that the output from
hostname(1) matches the return from gethostname(2), which in this case
it does. so the test still passes on those platforms:

$ cat /etc/lsb-release
[...]
DISTRIB_DESCRIPTION="Ubuntu 20.04.2 LTS"
$ ./ssh -o controlpath='%L' -G ::1 | grep controlpath
controlpath server01
$ ./ssh -o controlpath='%l' -G ::1 | grep controlpath
controlpath server01
$ make t-exec LTESTS=percent TEST_SSH_UNSAFE_PERMISSIONS=1
[...]
ok percent expansions
make[1]: Leaving directory '/home/dtucker/openssh/regress'
all t-exec passed
--
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA (new)
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.