Call for testing: OpenSSH 8.9

[chris]

On Wed, Feb 16, 2022 at 12:36:56PM +1100, Darren Tucker wrote:
> On Wed, 16 Feb 2022 at 00:48, chris <chris at cataclysmal.org> wrote:
> [...]
> > openssh-SNAP-20220215.tar.gz
> > Haiku R1/beta3 hrev55181+63 (x86)
> > gcc 11.2.0
> [...]
> > drop connection #1 from [127.0.0.1]:40281 on [127.0.0.1]:4242 past MaxStartups
> 
> This was the symptom we saw on Solaris and derivatives, which was
> caused by the privileged sshd not being a process group leader and
> thus the grace_alarm_handler fails to clean up the unprivileged
> privsep child here:
> 
> grace_alarm_handler(int sig)
> [...]
>         if (getpgid(0) == getpid()) {
>                 ssh_signal(SIGTERM, SIG_IGN);
>                 kill(0, SIGTERM);
>         }
> 
> On Solaris this was caused by skipping the setsid() call, but that was
> removed in commit b306986, so probably there's another thing causing a
> similar symptom.  Does Haiku implement the kill(0, ...) behaviour
> specified by posix?  Does have a killpg?  Does it even have process
> groups?



headers/posix/signal.h:242:

int     kill(pid_t pid, int _signal);
int             killpg(pid_t processGroupID, int _signal);