Call for testing: OpenSSH 10.0

Michael Forney mforney at mforney.org
Mon Apr 7 17:50:18 AEST 2025


Darren Tucker <dtucker at dtucker.net> wrote:
> OpenSSH 10.0p1 is almost ready for release, so we would appreciate testing
> on as many platforms and systems as possible. This is primarily a bugfix
> release, although one notable change is the introduction of the sshd-auth
> binary (see below).

I noticed that bbc9c18e84 added a use of time() but didn't include
<time.h>:

	sshd.c: In function 'drop_connection':
	sshd.c:622:41: error: implicit declaration of function 'time' [-Wimplicit-function-declaration]
	  622 |         ratelimited = log_ratelimit(rl, time(NULL), NULL, &ndropped);
	      |                                         ^~~~
	sshd.c:96:1: note: 'time' is defined in header '<time.h>'; this is probably fixable by adding '#include <time.h>'
	   95 | #include "atomicio.h"
	  +++ |+#include <time.h>
	   96 |

This only appears with --without-openssl, so <time.h> must be getting
transitively included through openssl headers. It might also be
specific to musl, since musl's headers often don't pull in as much
stuff as other libcs.


More information about the openssh-unix-dev mailing list