configure failure when whitespace in directory name

[Darren Tucker]

On Wed, 1 Oct 2025 at 10:34, Job Snijders <job at openbsd.org> wrote:

> [...]
> The above chunk helps a bit in relationship to the reproducer that OP
> provided (I tested on Debian 13): autoreconf && ./configure && make
> pass. However, 'make tests' throws this error:
>
[...]

>         [ -f `pwd`/regress/Makefile ] || \
>             ln -s `cd . && pwd`/regress/Makefile `pwd`/regress/Makefile
>         /usr/bin/bash: line 1: [: /home/job/openssh/o: binary operator
> expected
>         ln: target '2/openssh/regress/Makefile': No such file or directory
>         make: *** [Makefile:547: regress-prep] Error 1
>

This one is not new: that line was last changed in 2015 and 10.0p2 fails in
the same way with a space in the directory path.

I'll look at it but given it's been there for a while, if the fix is
invasive it might have to wait until after the release.


> And the below chunk does not apply cleanly to openssh-SNAP-20251001.tar.gz:
> [...]
> >  distclean: clean
> >       rm -f Makefile *~
> > +     rm -rf include
>

Not sure what happened there.  My guess is either I or a mailer somewhere
mangled it.  It's not significant for the purposes of testing, though.

Thanks for testing.

-- 
Darren Tucker (dtucker at dtucker.net)
GPG key 11EAA6FA / A86E 3E07 5B19 5880 E860  37F4 9357 ECEF 11EA A6FA
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.