FW: can function sftp_upload return OK even if an error message is received?

[Damien Miller]

On Tue, 30 Sep 2025, Damien Miller wrote:

> On Fri, 19 Sep 2025, Graziano Stefani (Nokia) via openssh-unix-dev wrote:
> 
> > Hi,
> >
> > Were there any conclusions on this subject? Can the proposed
> > fix (introducing variable status_2 to save the error in the
> > SSH2_FXP_STATUS message) be acceptable?
> 
> > -                       debug3("SSH2_FXP_STATUS %u", status);
> > +                       debug3("SSH2_FXP_STATUS %u", status_2);
> > +                       if (status == SSH2_FX_OK)
> > +                               status = status_2;
> 
> I think this patch is wrong. The condition should be != SSH2_FX_OK,
> otherwise the error is never stored.

I've committed this change and it will be in the openssh-10.1 release.
Due real soon.

-d