sandbox-darwin.c: sandbox.h is deprecated

[Sevan Janiyan]

On 17/08/2026 09:59, Darren Tucker wrote:
> Debugging via a Github hosted runner is possible but tedious, so I
> haven't had a chance to dig into it.  If you want to do so, I'd add a
> "set -x" to the top of the scp3.sh, run the test with "env
> TEST_SSH_FAIL_FATAL=yes make t-exec LTESTS=scp3" to cause it to stop
> at the first failure then examine the directories passed to the
> failing command and those reported by the error.

Thanks for the pointer.
 From the regress log files I see
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: read failed rfd 4 maxlen 32768: Broken pipe
debug2: channel 0: read failed
debug2: chan_shutdown_read: channel 0: (i0 o0 sock -1 wfd 4 efd 8 [write])

When it fails, it reckons it is creating a tar file containing the logs 
but regress/failed-scp3-logs.tar is missing.
regress/regress.log, regress/ssh.log, regress/sshd.log are present

The log files created by regress are in CR/LF format. Is that expected??


Snippet from the log files:

regress/ssh.log
debug1: Sending command: scp -r -t 
/Users/sme/openssh-portable/regress/copy.dd2
debug2: channel 0: request exec confirm 1
debug3: send packet: type 98
debug3: channel 0: classify type "session:command" (no TTY) as bulk
debug2: channel_set_xtype: labeled channel 0 as session:command 
(inactive timeout 0)
debug3: client_repledge: enter
debug1: pledge: fork
debug2: channel_input_open_confirmation: channel 0: callback done
debug2: channel 0: open confirm rwindow 0 rmax 32768
debug2: client_loop: session QoS is now non-interactive
debug2: channel 0: rcvd adjust 2097152
debug3: receive packet: type 99
debug2: channel_input_status_confirm: type 99 id 0
debug2: exec request accepted on channel 0
debug2: channel 0: rcvd adjust 98343
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 114688
debug2: channel 0: rcvd adjust 90112
debug2: channel 0: rcvd adjust 114688
debug2: channel 0: rcvd adjust 98304
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106179
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106145
debug2: channel 0: rcvd adjust 98344
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 114688
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 122880
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106166
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 114688
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 81920
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: rcvd adjust 106496
debug2: channel 0: read failed rfd 4 maxlen 32768: Broken pipe
debug2: channel 0: read failed
debug2: chan_shutdown_read: channel 0: (i0 o0 sock -1 wfd 4 efd 8 [write])
debug2: channel 0: input open -> drain
debug2: channel 0: ibuf empty
debug2: channel 0: send eof
debug3: send packet: type 96
debug2: channel 0: input drain -> closed
debug3: receive packet: type 96
debug2: channel 0: rcvd eof
debug2: channel 0: output open -> drain
debug2: channel 0: obuf empty
debug2: chan_shutdown_write: channel 0: (i3 o1 sock -1 wfd 7 efd 8 [write])
debug2: channel 0: output drain -> closed
debug3: receive packet: type 98
debug1: client_input_channel_req: channel 0 rtype exit-status reply 0
debug3: receive packet: type 97
debug2: channel 0: rcvd close
debug3: channel 0: will not send data after close
debug2: channel 0: almost dead
debug2: channel 0: gc: notify user
debug2: channel 0: gc: user detached
debug2: channel 0: send_close2
debug2: channel 0: send close for remote id 0
debug3: send packet: type 97
debug2: channel 0: is dead
debug2: channel 0: garbage collecting
debug1: channel 0: free: client-session, nchannels 1
debug3: channel 0: status: The following connections are open:
   #0 client-session (t4 [session:command] r0 nm0 i3/0 o3/0 e[write]/0 
fd -1/-1/8 sock -1 cc -1 nc0 io 0x00/0x00 B)

debug2: client_loop: session QoS is now interactive
debug3: send packet: type 1
Transferred: sent 4240060, received 7276 bytes, in 0.0 seconds
Bytes per second: sent 153753490.2, received 263843.1
debug1: Exit status 0
FAIL: corrupted copy


regress/sshd.log
debug2: fd 13 setting O_NONBLOCK
debug2: fd 12 setting O_NONBLOCK
debug2: fd 15 setting O_NONBLOCK
debug3: channel 0: classify type "session:command" (no TTY) as bulk
debug3: send packet: type 99
debug2: process_output: session QoS is now non-interactive
debug2: channel 0: window 1998809 sent adjust 98343
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1982464 sent adjust 114688
debug2: channel 0: window 1982464 sent adjust 114688
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1982464 sent adjust 114688
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1982781 sent adjust 114371
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990967 sent adjust 106185
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990986 sent adjust 106166
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1982464 sent adjust 114688
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug2: channel 0: window 1990656 sent adjust 106496
debug3: receive packet: type 96
debug2: channel 0: rcvd eof
debug2: channel 0: output open -> drain
debug2: channel 0: obuf empty
debug2: chan_shutdown_write: channel 0: (i0 o1 sock -1 wfd 12 efd 15 [read])
debug2: channel 0: output drain -> closed
debug2: channel 0: read failed rfd 13 maxlen 32768: Broken pipe
debug2: channel 0: read failed
debug2: chan_shutdown_read: channel 0: (i0 o3 sock -1 wfd 13 efd 15 [read])
debug2: channel 0: input open -> drain
debug2: channel 0: read 0 from efd 15
debug2: channel 0: closing read-efd 15
debug2: channel 0: ibuf empty
debug2: channel 0: send eof
debug3: send packet: type 96
debug2: channel 0: input drain -> closed
debug1: Received SIGCHLD.
debug1: session_by_pid: pid 4420
debug2: channel 0: request exit-status confirm 0
debug3: send packet: type 98
debug1: session_exit_message: session 0 channel 0 pid 4420 exit 0
debug1: session_exit_message: release channel 0
debug2: channel 0: send_close2
debug2: channel 0: send close for remote id 0
debug3: send packet: type 97
debug3: channel 0: will not send data after close
debug3: receive packet: type 97
debug2: channel 0: rcvd close
debug3: channel 0: will not send data after close
debug2: channel 0: is dead
debug2: channel 0: gc: notify user
debug1: session_by_channel: session 0 channel 0
debug1: session_close_by_channel: channel 0 child 0
Close session: user sme from UNKNOWN port 65535 id 0
debug3: session_unused: session id 0 unused
debug2: channel 0: gc: user detached
debug2: channel 0: is dead
debug2: channel 0: garbage collecting
debug1: channel 0: free: server-session, nchannels 1
debug3: mm_request_receive: entering
debug3: mm_request_receive: monitor fd closed
mm_reap: child terminated by signal 1
debug1: do_cleanup
FAIL: corrupted copy


regress/failed-sshd.log
debug2: channel 0: rcvd adjust 8192
debug2: channel 0: rcvd adjust 8192
debug2: channel 0: read failed rfd 13 maxlen 32768: Broken pipe
debug2: channel 0: read failed
debug2: chan_shutdown_read: channel 0: (i0 o0 sock -1 wfd 13 efd 15 [read])
debug2: channel 0: input open -> drain
debug2: channel 0: read 0 from efd 15
debug2: channel 0: closing read-efd 15
debug2: channel 0: ibuf empty
debug2: channel 0: send eof
debug3: send packet: type 96
debug2: channel 0: input drain -> closed
debug1: Received SIGCHLD.
debug1: session_by_pid: pid 4713
debug2: channel 0: request exit-status confirm 0
debug3: send packet: type 98
debug1: session_exit_message: session 0 channel 0 pid 4713 exit 0
debug1: session_exit_message: release channel 0
debug2: channel 0: write failed
debug2: chan_shutdown_write: channel 0: (i3 o0 sock -1 wfd 12 efd -1 
[closed])
debug2: channel 0: send eow
debug3: send packet: type 98
debug2: channel 0: output open -> closed
debug2: channel 0: send_close2
debug2: channel 0: send close for remote id 0
debug3: send packet: type 97
debug3: channel 0: will not send data after close
debug3: receive packet: type 97
debug2: channel 0: rcvd close
debug3: channel 0: will not send data after close
debug2: channel 0: is dead
debug2: channel 0: gc: notify user
debug1: session_by_channel: session 0 channel 0
debug1: session_close_by_channel: channel 0 child 0
Close session: user sme from UNKNOWN port 65535 id 0
debug3: session_unused: session id 0 unused
debug2: channel 0: gc: user detached
debug2: channel 0: is dead
debug2: channel 0: garbage collecting
debug1: channel 0: free: server-session, nchannels 1
debug3: channel 0: status: The following connections are open:
   #0 server-session (t4 [session:command] r0 nm0 i3/0 o3/0 e[closed]/0 
fd -1/-1/-1 sock -1 cc -1 nc0 io 0x00/0x00 B)

debug3: receive packet: type 1
debug3: mm_request_receive: entering
debug3: mm_request_receive: monitor fd closed
mm_reap: child terminated by signal 1
debug1: do_cleanup
FAIL: corrupted copy

Sevan