[netflow-tools] "Fatal error - exiting immediately"

[Damien Miller]

On Thu, 17 Nov 2005, Tony and Robyn Lewis wrote:

> Damien Miller wrote:
>
>>
>> Try this, it shouldn't matter unless your compiler is buggy.
>
> softflowd.c:1749: error: incompatible type for argument 1 of 'memset'

oops, bad patch. Try this one (revert the last with "patch -R < 
softflowd-zero.diff" first). Or, don't worry about it, since you have 
found the real problem :)

> Aha!  I reconfigured and remade with gcc-3.3 and she seems to be working.
>
> Is GCC 4.0 buggy?

It is very buggy. There have been a spate of bugs reported to OpenSSH that 
have been traced to gcc-4.x miscompilations, though Linux/x86 hasn't been 
as bad as more obscure platforms. I would avoid it for quite a few 
versions yet...

-d
-------------- next part --------------
Index: softflowd.c
===================================================================
RCS file: /var/cvs/softflowd/softflowd.c,v
retrieving revision 1.84
diff -u -p -r1.84 softflowd.c
--- softflowd.c	1 Oct 2005 00:14:21 -0000	1.84
+++ softflowd.c	17 Nov 2005 00:55:45 -0000
@@ -1749,6 +1755,7 @@ main(int argc, char **argv)
 	/* Main processing loop */
 	gettimeofday(&flowtrack.system_boot_time, NULL);
 	stop_collection_flag = 0;
+	memset(&cb_ctxt, '\0', sizeof(cb_ctxt));
 	cb_ctxt.ft = &flowtrack;
 	cb_ctxt.linktype = linktype;
 	cb_ctxt.want_v6 = target.dialect->v6_capable || always_v6;