[Bug 1208] ssh fails to remove control socket when ssh is abnormally terminated

[bugzilla-daemon at bugzilla.mindrot.org]

http://bugzilla.mindrot.org/show_bug.cgi?id=1208


Daniel Black <dragonheart at gentoo.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |dragonheart at gentoo.org




--- Comment #18 from Daniel Black <dragonheart at gentoo.org>  2007-06-22 18:25:03 ---
Not enough sorry.
The below example used OpenSSH_4.6p1 with the attached patch
A ssh connection was made (and a control socket was created). The ssh
connection was killed with a kill -9 from another terminal. An attempt
to reconnect was made and this failed as per below:

localhost $ ssh devgentoo
Enter passphrase for key '/home/dan/.ssh/id_dsa':
Last login: Fri Jun 22 08:05:10 2007 from 59.167.43.249
HP ProLiant DL380 G5 Server
dragonheart at woodpecker ~ $ Killed

localhost ~ $ ssh devgentoo
Control socket
connect(/home/dan/.ssh/master-dragonheart at dev.gentoo.org:22):
Connection refused
Enter passphrase for key '/home/dan/.ssh/id_dsa':
ControlSocket /home/dan/.ssh/master-dragonheart at dev.gentoo.org:22
already exists

localhost ~ $ ssh -v
OpenSSH_4.6p1, OpenSSL 0.9.8d 28 Sep 2006

Recommendation:
a) delete the control socket when a connection refused occurs (the
connection obviously isn't much use anyway)

I'm not sure of all the things that could cause a connection refused
but given its local I don't think there would be too many options.

b) create a different socket name if you get a "already exists" error
like maketemp though a) would be easier.


-- 
Configure bugmail: http://bugzilla.mindrot.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are watching the assignee of the bug.