[Bug 3416] sshd freeze when build without HAVE_PPOLL

bugzilla-daemon at mindrot.org bugzilla-daemon at mindrot.org
Fri Apr 1 23:38:22 AEDT 2022


--- Comment #5 from Darren Tucker <dtucker at dtucker.net> ---
(In reply to Damien Miller from comment #4)
> Looks good to me. Although unrelated, I think the POLLIN case should
> check (revents & (POLLIN|POLLHUP)) as this can be returned too (not
> sure whether without POLLIN too).

I don't follow: it's not checking revents that will be returned from
poll(), it's checking events that were passed to poll().  According to
the man page POLLHUP is meaningless and ignored in events and only
meaningful in revents (which we're not checking).

> Also maybe both POLLIN and POLLOUT cases should check POLLERR in
> revents. I saw this in bug #3405

Good point, I'll do that as a separate patch.

You are receiving this mail because:
You are watching someone on the CC list of the bug.
You are watching the assignee of the bug.

More information about the openssh-bugs mailing list