Solaris/IRIX audit support: login.c vs loginrec.c

[Gregory Leblanc]

> -----Original Message-----
> From: Rip Loomis [mailto:loomisg at cist.saic.com]
> Sent: Wednesday, August 30, 2000 11:52 AM
> To: openssh-unix-dev at mindrot.org
> Subject: Solaris/IRIX audit support: login.c vs loginrec.c
> 
> Comments requested:
> I have internally-generated patches against
> commercial SSH 1.2.27 that add full support
> for generation of kernel-level audit data
> on Solaris 2.5.1+ and IRIX 6.2/6.5, and
> I'm finally getting around to porting them
> to OpenSSH.
> 
> One piece that had been previously implemented
> was generation of login/logout events in
> record_login and record_logout in login.c--but
> now those functions are mostly shells for the
> stuff in loginrec.c.  It looks as though it
> would be easier for me to just drop these
> into login.c, but the functionality might
> be more useful to other projects if it was
> integrated into loginrec.c.
> 
> What's the best answer?

It seems to me that the best answer is the one that's most architecturally
sound, so putting it into loginrec.c seems to make the most sense, but it
may not be easiest.  Please keep in mind that IANAH, so I may be unduly
biased.

> Related questions:
> 1.  Will anyone besides me (and certain
> customers) actually use this sort of 
> functionality?

I'd probably use that on my machines at home, assuming that I've read this
correctly.  I've got machines using Solaris 2.7/2.8, and IRIX 6.5, although
none of them have working compilers right now.  Later,
	Greg