PATCH: Datafellows SSH misdetection in compat.c

Pekka Savola pekkas at netcore.fi
Sun Dec 3 03:06:56 EST 2000


Hello all,

All SSH/Datafellows versions don't match properly in compat.c.  This
should be fixed in OpenBSD version, naturally.  An example of this is:

debug: match: 2.1.0.pl2 SSH Secure Shell (non-commercial) pat ^2\.

The match should definitely be 2.1.0.  This is caused by the fact that
a requisite space was added to the check when converting to regexp matching
on Oct 10; CVS Id 1.24:

http://www.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/compat.c?r1=1.23&r2=1.24

More information about the problem:

http://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=21509

Patch attached.

-- 
Pekka Savola                    "Tell me of difficulties surmounted,
Netcore Oy                      not those you stumble over and fall"
Systems. Networks. Security.     -- Robert Jordan: A Crown of Swords
-------------- next part --------------
--- compat.c.orig	Sun Nov  5 07:42:36 2000
+++ compat.c	Sat Dec  2 17:58:56 2000
@@ -64,12 +64,12 @@
 	} check[] = {
 		{ "^OpenSSH[-_]2\\.[012]",	SSH_OLD_SESSIONID },
 		{ "MindTerm",		0 },
-		{ "^2\\.1\\.0 ",	SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
+		{ "^2\\.1\\.0",		SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
 					SSH_OLD_SESSIONID },
 		{ "^2\\.0\\.",		SSH_BUG_SIGBLOB|SSH_BUG_HMAC|
 					SSH_OLD_SESSIONID|
 					SSH_BUG_PUBKEYAUTH|SSH_BUG_X11FWD },
-		{ "^2\\.[23]\\.0 ",	SSH_BUG_HMAC},
+		{ "^2\\.[23]\\.0",	SSH_BUG_HMAC},
 		{ "^2\\.[2-9]\\.",	0 },
 		{ "^2\\.4$",		SSH_OLD_SESSIONID}, /* Van Dyke */
 		{ "^3\\.0 SecureCRT",	SSH_OLD_SESSIONID},


More information about the openssh-unix-dev mailing list