[patch] VPN enhancements

Markus Friedl Markus.Friedl at informatik.uni-erlangen.de
Mon Jul 23 01:43:40 EST 2001


On Sun, Jul 22, 2001 at 03:00:24PM +0100, Matthew Vernon wrote:
> Markus Friedl <Markus.Friedl at informatik.uni-erlangen.de> writes:
> 
> > 
> > On Sun, Jul 22, 2001 at 12:56:38PM +0100, Matthew Vernon wrote:
> > > +void alarm_catch (int signum)
> > > +{
> > > +        if(signum!=SIGALRM) return;
> > > +	else fatal("ssh_exchange_identification: Timeout waiting for version information.");
> > > +}
> > 
> > please not alarm() and signal handling.
> > signals should not be used at all.
> 
> Why on earth not? You'll notice that this patch is very careful to
> avoid doing bad things (or careless things) with signals.

for example: fatal() is not allowed in signal handlers since it calls exit().



More information about the openssh-unix-dev mailing list