OSF/1 or Tru64 patch for Privsep

[SCHINCKE, KEITH (JSC-SM) (LM)]

Remote execution works with privsep turned off.

Ok, I have traced some things down to where the program stops. 

session.c:do_child() calls the privsep wrapper for setup_sia (mm_setup_sia
is actuall called)
	s->ttyfd is -1 so NULL passed in as the tty.
monitor_wrap.c:mm_setup_sia calls buffer_put_cstring(&m, tty)
bufaux.c:buffer_put_cstring calls fatal() when s is NULL. 


I am still new to looking at the code but why not do
	'buffer_put_string(&m,tty,strlen(tty));'
in monitor_wrap.c:mm_setup_sia?


-----Original Message-----
From: Ben Lindstrom [mailto:mouring at etoh.eviladmin.org]
Sent: Monday, August 12, 2002 1:31 PM
To: SCHINCKE, KEITH (JSC-SM) (LM)
Cc: OpenSSH Development
Subject: RE: OSF/1 or Tru64 patch for Privsep



Every also test w/ and w/out Privsep so we don't break the non-privsep
case. (That would be a *REAL* shame if we did. <weak smile>)

- Ben


On Mon, 12 Aug 2002, SCHINCKE, KEITH (JSC-SM) (LM) wrote:

> HAVE_OSF_SIA yes
> X11 forward yes
> remote command execution fails with "buffer_put_cstring: s == NULL"
>
> I am looking into where things failing at.
>
> -----Original Message-----
> From: Ben Lindstrom [mailto:mouring at etoh.eviladmin.org]
> Sent: Monday, August 12, 2002 11:08 AM
> To: SCHINCKE, KEITH (JSC-SM) (LM)
> Cc: OpenSSH Development
> Subject: RE: OSF/1 or Tru64 patch for Privsep
>
>
>
> try everything... X11 forward, port forwarding, executing remote commands.
>
> Everything needs to be tested.. Also check to ensure HAVE_OSF_SIA is set
> in your config.h.
>
> - Ben
>
> On Mon, 12 Aug 2002, SCHINCKE, KEITH (JSC-SM) (LM) wrote:
>
> > Hey Ben,
> >
> > I pulled the latest snap shot (20020801) and got your patch to apply
with
> > only one chunk rejected.
> >
> > I have been able to login with the new code using the OpenSSH client,
> > ssh.com 3.1.0 and putty 0.52.
> >
> > "It works for me."
> >
> > Any other data points you are interested in?
> >
> > Thanks for the work you put into this.
> >
> > Keith
> >
> > -----Original Message-----
> > From: Ben Lindstrom [mailto:mouring at etoh.eviladmin.org]
> > Sent: Sunday, August 11, 2002 5:38 PM
> > To: OpenSSH Development
> > Subject: OSF/1 or Tru64 patch for Privsep
> >
> >
> >
> > Either this never made it to the list or no one cares about Tru64.  This
> > is the last time I'll send this patch to the list.  If no one steps up
and
> > finishes it or provides me with enough information to fix any remaining
> > bugs (one being complaint that 'ssh site cmd' does not work right).
> >
> > If there is no activity on this for a week.  I'll post it to bugzilla
and
> > will ignore any request for me to fix Tru64.
> >
> > I do thank everyone that has privately contributed help in regards to
> > testing and such.
> >
> > This patch may apply to 3.4p1, but I'd perfer testing to be done on
-cvs.
> >
> > - Ben
> >
>