OSF/1 or Tru64 patch for Privsep

Peter Stuge stuge-openssh-unix-dev at cdy.org
Tue Aug 13 12:26:28 EST 2002

On Mon, Aug 12, 2002 at 02:08:35PM -0500, SCHINCKE, KEITH (JSC-SM) (LM) wrote:
> 	s->ttyfd is -1 so NULL passed in as the tty.
> monitor_wrap.c:mm_setup_sia calls buffer_put_cstring(&m, tty)
> bufaux.c:buffer_put_cstring calls fatal() when s is NULL. 
> I am still new to looking at the code but why not do
> 	'buffer_put_string(&m,tty,strlen(tty));'
> in monitor_wrap.c:mm_setup_sia?

strlen(NULL) is bad.  It will try to access memory att address 0 and cause
an access violation.  Instead maybe add

  if(tty != NULL)

in monitor_wrap.c:mm_setup_sia() before the call to buffer_put_cstring()

(Please note that this might be a bad idea, I haven't been following this
thread closely.)


More information about the openssh-unix-dev mailing list