OpenSSH 3.2.2 released

Kevin Steves kevin at atomicgears.com
Wed May 22 04:00:36 EST 2002


On Fri, May 17, 2002 at 12:40:24PM +0200, Corinna Vinschen wrote:
> Why has the setgroups() call been added to sshd.c a week ago
> w/o asking for further testing?  It doesn't exist in Cygwin.
> All other setgroups() calls are #ifndef'd HAVE_CYGWIN.  Why
> not this one? 

This is the change I just commited:

Index: sshd.c
===================================================================
RCS file: /var/cvs/openssh/sshd.c,v
retrieving revision 1.206
diff -u -r1.206 sshd.c
--- sshd.c	21 May 2002 17:50:21 -0000	1.206
+++ sshd.c	21 May 2002 17:57:25 -0000
@@ -1005,6 +1005,7 @@
 	if (test_flag)
 		exit(0);
 
+#ifndef HAVE_CYGWIN
 	/*
 	 * Clear out any supplemental groups we may have inherited.  This
 	 * prevents inadvertent creation of files with bad modes (in the
@@ -1014,6 +1015,7 @@
 	 */
 	if (setgroups(0, NULL) < 0)
 		debug("setgroups() failed: %.200s", strerror(errno));
+#endif /* !HAVE_CYGWIN */
 
 	/* Initialize the log (it is reinitialized below in case we forked). */
 	if (debug_flag && !inetd_flag)



More information about the openssh-unix-dev mailing list