privsep patch, Please test

[Mathias Koerber]

> -----Original Message-----
> From: Tim Rice [mailto:tim at multitalents.net]
> Sent: Thursday, May 30, 2002 10:49 AM
> To: Mathias Koerber
> Cc: OpenSSH Development
> Subject: RE: privsep patch, Please test
> 
> 
> On Thu, 30 May 2002, Mathias Koerber wrote:
> 
> > > This was talked about a few posts ago.  Go to where the 
> mmap() call is for
> > > the alternation version and change MAP_PRIVATE to MAP_SHARED
> >
> > If I do that (after applying Tim's privsep.patch),thusly:
> >
> >  #ifdef HAVE_MMAP
> >  #ifdef HAVE_WORKING_MAP_ANONYMOUS
> >          address = mmap(NULL, size, PROT_WRITE|PROT_READ,
> > MAP_ANON|MAP_SHARED,
> >              -1, 0);
> >  #else
> > +        address = mmap(NULL, size, PROT_WRITE|PROT_READ, MAP_PRIVATE,
> > -        address = mmap(NULL, size, PROT_WRITE|PROT_READ, MAP_SHARED,
> 
> This looks backwards. My patch had,
>        address = mmap(NULL, size, PROT_WRITE|PROT_READ, MAP_PRIVATE,
> should have had,
>         address = mmap(NULL, size, PROT_WRITE|PROT_READ, MAP_SHARED,

That's the change I made based on Ben's suggestion..

> 
> What platform are you on?

Linux 2.2.13

>
>