privsep patch, Please test (take 2)

Tim Rice tim at multitalents.net
Fri May 31 03:24:07 EST 2002


On Thu, 30 May 2002, Ben Lindstrom wrote:

>
>
> Ermm.. I think your configure.ac is invalid.
>
> Two things.
>
> 1. Lack of MAP_ANON/MAP_ANONYMOUS does not mean mmap is broken.  Just
> means it lacks a useful feature.

True. Look again. the test doesn't fail on lack on MAP_ANON

>
> 2. Linux 2.2 has a MAP_ANON but it's broken.  But that is a seperate issue
> from the fact that MAP_SHARED seems also to be broken.  I think they need
> to be tested seperately.
>
> Because if MAP_ANON is not useful (does not exist) we have a fallback
> plan.  However if MAP_SHARED is broken.  We are SOL.

Do we want to someone on a 2.2 kernel to be able to enable privsep
and then have it fail if the client requests compression?

With MAP_PRIVATE, on linux 2.2 it will work until  you use compression.

>
> - Ben
>
> On Thu, 30 May 2002, Tim Rice wrote:
>
> >
> > It looks like mmap() with MAP_SHARED just doesn't work on Linux 2.2
> > so i'm releasing a new patch.
> > See http://mail.nl.linux.org/linux-mm/1999-01/msg00034.html
> >
> > On Wed, 29 May 2002, Tim Rice wrote: (and then revised)
> >
> > Please try the attached patch. It adds support for platforms that
> > have mmap() but do not support MAP_ANONYMOUS.
> > Ie. UnixWare 2.x, Solaris < 8
> >
> > You'll need autoconf 2.52 installed
> > Run autoreconf after applying the patch.
> >
> > If you don't have autoconf 2.52 installed,
> > grab the new configure from
> > 	http://www.multitalents.net/openssh/configure-privsep-2.gz
> > or
> > 	ftp://ftp.multitalents.net/pub/openssh/configure-privsep-2.gz
> > and add the following line to config.h.in
> > #undef HAVE_BROKEN_MMAP
> >
> > It works on UnixWare 2.1.3, and Solaris 7.
> > (In addition to the platforms that worked before)
> >
> > It doesn't work with SCO yet. A problem with sendmsg() in mm_receive_fd()
> >
> > I'd like to hear from other platforms that this helps.
> >
> >
> > --
> > Tim Rice				Multitalents	(707) 887-1469
> > tim at multitalents.net
> >
> >
> >
>

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net





More information about the openssh-unix-dev mailing list