Call for testing for 3.5 OpenSSH

Darren Tucker dtucker at zip.com.au
Wed Sep 25 15:44:06 EST 2002


Gert Doering wrote:
> On Tue, Sep 24, 2002 at 08:57:22AM -0500, Ben Lindstrom wrote:
> > > 2) http://bugzilla.mindrot.org/show_bug.cgi?id=397
> > > strsep() is in libc but isn't defined in the headers unless
> > > _LINUX_SOURCE_COMPAT is defined. This doesn't affect GCC, only the
> > > native compiler.  Apart from the patch, another option could be to have
> > > configure define _LINUX_SOURCE_COMPAT for AIX.
> >
> > Is this only an issue under 4.3.3 or this also an issue with 5.1?  I
> > understand other's concern in regards to sublevels of 4.3.3.
> 
> As far as I understand it's only an issue for 4.3.3, and it only affects
> binary compatibility between 4.3.3 sublevels.

It also affects builds using the native compiler on higher maintenance
levels, see below.

> > I would be willing to set it for all 4.3.3 and lower to use our internal
> > strsep and allow 5.1 to use the native one if 5.1 is fine.  Just coding to
> > detect such things is normally ugly.
> 
> I think it might just work to do a "don't care" here - if configure finds
> it (due to headers *and* library being available), use it.  If not, use
> the internal one.

I don't care either, as long as it works, however as it stands it won't
compile at all on 4.3.3.x using xlc.
On 4.3.3.x with the default compiler flags, strsep is in the library but
not the header.

Configure finds strsep in libc (because it's there) and defines
HAVE_STRSEP but as it has no prototype xlc throws a type mismatch.

(For values of x>6? Which ML introduced the change to libc?)

> I want to vote *against* doing special-casing for AIX here - let them
> get their headers right.  strsep() isn't *that* big, just compile it in.

You might be able to do a better check in configure, but the stock test
is fooled (I think because the test contains 
"char $ac_func ();"

-- 
Darren Tucker (dtucker at zip.com.au)
GPG Fingerprint D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.



More information about the openssh-unix-dev mailing list