Call for testing for 3.5 OpenSSH

[Darren Tucker]

Darren Tucker wrote:
> Gert Doering wrote:
> > On Tue, Sep 24, 2002 at 08:57:22AM -0500, Ben Lindstrom wrote:
> > > > 2) http://bugzilla.mindrot.org/show_bug.cgi?id=397
> > > > strsep() is in libc but isn't defined in the headers unless
> > > > _LINUX_SOURCE_COMPAT is defined. This doesn't affect GCC, only the
> > > > native compiler.  Apart from the patch, another option could be to have
> > > > configure define _LINUX_SOURCE_COMPAT for AIX.
> >
> > I want to vote *against* doing special-casing for AIX here - let them
> > get their headers right.  strsep() isn't *that* big, just compile it in.

How about the following patch to configure.ac? It doesn't special case
AIX but it does check for the strsep prototype before checking for the
library function and defining HAVE_STRSEP.

I tested on AIX 4.3.3 with xlc (which didn't define HAVE_STRSEP) and
Linux (which did).

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
-------------- next part --------------
Index: configure.ac
===================================================================
RCS file: /cvs/openssh/configure.ac,v
retrieving revision 1.89
diff -u -r1.89 configure.ac
--- configure.ac	26 Sep 2002 00:38:47 -0000	1.89
+++ configure.ac	26 Sep 2002 12:13:09 -0000
@@ -604,8 +604,11 @@
 	realpath recvmsg rresvport_af sendmsg setdtablesize setegid \
 	setenv seteuid setgroups setlogin setproctitle setresgid setreuid \
 	setrlimit setsid setpcred setvbuf sigaction sigvec snprintf \
-	socketpair strerror strlcat strlcpy strmode strsep sysconf tcgetpgrp \
+	socketpair strerror strlcat strlcpy strmode sysconf tcgetpgrp \
 	truncate utimes vhangup vsnprintf waitpid __b64_ntop _getpty)
+
+dnl Make sure strsep prototype is defined before defining HAVE_STRSEP
+AC_CHECK_DECL(strsep, [AC_CHECK_FUNCS(strsep)])
 
 dnl IRIX and Solaris 2.5.1 have dirname() in libgen
 AC_CHECK_FUNCS(dirname, [AC_CHECK_HEADERS(libgen.h)] ,[