[PATCH] Fix minor breakage on Cygwin: auth-passwd.c and session.c

Corinna Vinschen vinschen at redhat.com
Mon Aug 11 19:55:28 EST 2003


Sorry for the late response, I was on vacation.

On Mon, Aug 04, 2003 at 12:32:36AM -0500, Ben Lindstrom wrote:
> On Mon, 4 Aug 2003, Darren Tucker wrote:
> > Ben Lindstrom wrote:
> > > [..]
> > > +# ifdef HAVE_CYGWIN
> > > +#  undef ERROR
> > > +#  include <windows.h>
> > > +#  include <sys/cygwin.h>
> > > +#  define is_winnt       (GetVersion() < 0x80000000)
> > > +# endif
> > >
> > > There is enough of this junk laying around in different files it really
> > > should be put in an openbsd-compat/port-cygwin.h =)

Well, this isn't more "junk" than the extra stuff necessary for any
other OS.

> However, yes.  The code should go to bsd-cygwin_util.h unless there is
> some overriding reason not to... Corinna is there a reason we shouldn't
> make this change?

No.  But why is it still in xcrypt.c?  It's in xcrypt.c just because it
doesn't include openbsd-compat.h.  Is there any good reason not to do that?

Corinna

-- 
Corinna Vinschen
Cygwin Developer
Red Hat, Inc.
mailto:vinschen at redhat.com




More information about the openssh-unix-dev mailing list