[PATCH] Fix minor breakage on Cygwin: auth-passwd.c andsession.c

[Darren Tucker]

Corinna Vinschen wrote:
> On Mon, Aug 04, 2003 at 12:32:36AM -0500, Ben Lindstrom wrote:
> > > > There is enough of this junk laying around in different files it really
> > > > should be put in an openbsd-compat/port-cygwin.h =)
> 
> Well, this isn't more "junk" than the extra stuff necessary for any
> other OS.

Er, I think the smiley at the end implied that "junk" meant "unnecessary
platform specific code".

As auth-passwd.c must be periodically synced with the OpenBSD tree,
keeping platform specific code out of it where possible makes that
easier.  Compare auth-passwd.c from 3.6.1p2, OpenBSD and -current (after
Ben's cleanup).

> > However, yes.  The code should go to bsd-cygwin_util.h unless there is
> > some overriding reason not to... Corinna is there a reason we shouldn't
> > make this change?
> 
> No.  But why is it still in xcrypt.c?  It's in xcrypt.c just because it
> doesn't include openbsd-compat.h.  Is there any good reason not to do that?

It's included indirectly:
xcrypt.c -> includes.h -> openbsd-compat.h -> bsd-cygwin_util.h

Now the code in question is in bsd-cygwin_util.h it doesn't need to be in
xcrypt.c any more either.  I'll take it out.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.