Patch for a port forwarding problem in serverloop.c

[Markus Friedl]

On Sat, Feb 22, 2003 at 04:58:27PM -0500, jam at McQuil.com wrote:
> On Sat, 22 Feb 2003, Markus Friedl wrote:
> 
> > hm, ssh protocol messages should be used and the
> > client should close the connection, not the server.
> 
> Yes, that makes perfect sense, but how does the client know that the 
> server is unable to bind to that port ?
> 
> I see in the code, that the 'want_reply' is tested, and if
> true, it will send either a SUCCESS or FAILURE packet.
> 
> But, the 'want-reply' is false.  Well, at least it is when
> using a 3.1p1 client.
> 
> I just tried it with a 3.4p1 and a 3.5p1 client, and they both
> set want_reply = 1.  Seems good.
> 
> Except... the client prints:
> 
>  'Warning: remote port forwarding failed for listen port 5000'
> 
> But doesn't exit.
> 
> So, seems like a bug in the client.

i'm not sure about this.  but there should be a client flag
like 'exit if bind fails'.

-m