OpenSSH 3.7 testing (Re: 3.6p1 bug on SCO OpenServer)

[Ben Lindstrom]

On Sat, 13 Sep 2003, Brian Poole wrote:

> Quoting Ben Lindstrom (mouring at etoh.eviladmin.org) from  6 September 2003:
> >
> > On this note I think it would be best to opening the floor for testing of
> > the current CVS tree.  OpenSSH is in a feature lock and we should be in
> > in sync with the OpenBSD tree (there may be stray patches, but hopefully
> > nothing major).
> >
> > So please if we can get people to start doing tests on their platform is
> > would help.
>
> I've done some testing on Solaris and found one problem and another nit.
> Testing was done on Solaris 7, 8 & 9, with various OpenSSL versions, and
> Forte & GCC compilers.
>
> It appears that the regress Makefile is not portable enough. Solaris
> make in particular pukes on it currently (GNU make works fine.)
>
> $ make clean
> rm -f *.o *.a ssh sshd ssh-add ssh-keygen ssh-keyscan ssh-keysign ssh-agent scp ssh-rand-helper sftp-server sftp logintest config.cache config.log
> rm -f *.out core
> (cd openbsd-compat && make clean)
> rm -f *.o *.a core
> (cd regress && make clean)
> make: Fatal error in reader: Makefile, line 3: Badly formed macro assignment
> Current working directory /tmp/openssh-cvs/regress
> *** Error code 1
> make: Fatal error: Command failed for target `clean'
>


but t-exec: works?

Does it work if you do:

clean:
        @for F in $(CLEANFILES); do rm -f $(OBJ)/${F}; done
	rm -f authorized_keys_${USER}

[..]

CLEANFILES += known_hosts pidfile \
                ssh_config ssh_proxy sshd_config sshd_proxy \
                rsa.pub rsa rsa1.pub rsa1 host.rsa host.rsa1 \
                rsa-agent rsa-agent.pub rsa1-agent rsa1-agent.pub \
                ls.copy remote_pid

I'm wondering if the $${F} is tripping up Solaris' makefile.

> > BTW, regression testing should hopefully work for most platforms.  Please
> > get in the habbit of using this.  It should give us a better handle on
> > platform breakage.  Darren was nice enough to get that rolling recently.
> >
> > It should be as simple as ./configure [needed options] && make && make
> > tests, but I've not had a chance to confirm it with an actually test on my
> > Solaris test box.
>
> The regress suite looks good, a big thanks for getting it working. My
> nit here is that I think the yes-head test should verify that yes exists

Darren and Tim already fixed this so it should be more portable.

- Ben