OpenSSH 4.1: call for testing.

[guyverdh at mchsi.com]

I had already removed the "SunSSH" packages.

I have yet to "make install" the new code yet, so the PATH'ing shouldn't have
been an issue.

I did, however, add /tech_svc/SSH/opessn-4.0p1 to the PATH env-var, and re-ran
the  gmake tests LTESTS=multiplex

with no changes apparent

I then modified my PATH to include ./ as the last element, with no differences.

Then I changed the entry /bin/ls to /usr/bin/ls since /bin is a sym-link to
/usr/bin, with no change in output.

I finally ran gmake install, then re-ran the tests, and the tests succeeded.

ie - apparently, it's trying to run SCP from the installed directory, instead of
the directory where it had been compiled.

Wouldn't we want tests to succeed, before running the install?


 gmake tests LTESTS=multiplex
(cd openbsd-compat && gmake)
gmake[1]: Entering directory `/tech_svc/SSH/openssh-4.0p1/openbsd-compat'
gmake[1]: Nothing to be done for `all'.
gmake[1]: Leaving directory `/tech_svc/SSH/openssh-4.0p1/openbsd-compat'
BUILDDIR=`pwd`; \
[ -d `pwd`/regress ]  ||  mkdir -p `pwd`/regress; \
[ -f `pwd`/regress/Makefile ]  || \
    ln -s `cd . && pwd`/regress/Makefile `pwd`/regress/Makefile ; \
TEST_SHELL="sh"; \
TEST_SSH_SSH="${BUILDDIR}/ssh"; \
TEST_SSH_SSHD="${BUILDDIR}/sshd"; \
TEST_SSH_SSHAGENT="${BUILDDIR}/ssh-agent"; \
TEST_SSH_SSHADD="${BUILDDIR}/ssh-add"; \
TEST_SSH_SSHKEYGEN="${BUILDDIR}/ssh-keygen"; \
TEST_SSH_SSHKEYSCAN="${BUILDDIR}/ssh-keyscan"; \
TEST_SSH_SFTP="${BUILDDIR}/sftp"; \
TEST_SSH_SFTPSERVER="${BUILDDIR}/sftp-server"; \
cd ./regress || exit $?; \
gmake \
        .OBJDIR="${BUILDDIR}/regress" \
        .CURDIR="`pwd`" \
        BUILDDIR="${BUILDDIR}" \
        OBJ="${BUILDDIR}/regress/" \
        PATH="${BUILDDIR}:${PATH}" \
        TEST_SHELL="${TEST_SHELL}" \
        TEST_SSH_SSH="${TEST_SSH_SSH}" \
        TEST_SSH_SSHD="${TEST_SSH_SSHD}" \
        TEST_SSH_SSHAGENT="${TEST_SSH_SSHAGENT}" \
        TEST_SSH_SSHADD="${TEST_SSH_SSHADD}" \
        TEST_SSH_SSHKEYGEN="${TEST_SSH_SSHKEYGEN}" \
        TEST_SSH_SSHKEYSCAN="${TEST_SSH_SSHKEYSCAN}" \
        TEST_SSH_SFTP="${TEST_SSH_SFTP}" \
        TEST_SSH_SFTPSERVER="${TEST_SSH_SFTPSERVER}" \
        EXEEXT="" \
        tests
gmake[1]: Entering directory `/tech_svc/SSH/openssh-4.0p1/regress'
ssh-keygen -if /tech_svc/SSH/openssh-4.0p1/regress/rsa_ssh2.prv | diff -
/tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.prv
cat /tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.prv >
/tech_svc/SSH/openssh-4.0p1/regress//t2.out
chmod 600 /tech_svc/SSH/openssh-4.0p1/regress//t2.out
ssh-keygen -yf /tech_svc/SSH/openssh-4.0p1/regress//t2.out | diff -
/tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.pub
ssh-keygen -ef /tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.pub
>/tech_svc/SSH/openssh-4.0p1/regress//rsa_secsh.pub
ssh-keygen -if /tech_svc/SSH/openssh-4.0p1/regress//rsa_secsh.pub | diff -
/tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.pub
rm -f /tech_svc/SSH/openssh-4.0p1/regress/rsa_secsh.pub
ssh-keygen -lf /tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.pub |\
        awk '{print $2}' | diff - /tech_svc/SSH/openssh-4.0p1/regress/t4.ok
ssh-keygen -Bf /tech_svc/SSH/openssh-4.0p1/regress/rsa_openssh.pub |\
        awk '{print $2}' | diff - /tech_svc/SSH/openssh-4.0p1/regress/t5.ok
ssh-keygen -if /tech_svc/SSH/openssh-4.0p1/regress/dsa_ssh2.prv >
/tech_svc/SSH/openssh-4.0p1/regress//t6.out1
ssh-keygen -if /tech_svc/SSH/openssh-4.0p1/regress/dsa_ssh2.pub >
/tech_svc/SSH/openssh-4.0p1/regress//t6.out2
chmod 600 /tech_svc/SSH/openssh-4.0p1/regress//t6.out1
ssh-keygen -yf /tech_svc/SSH/openssh-4.0p1/regress//t6.out1 | diff -
/tech_svc/SSH/openssh-4.0p1/regress//t6.out2
ssh-keygen -lf /tech_svc/SSH/openssh-4.0p1/regress//t7.out > /dev/null
ssh-keygen -Bf /tech_svc/SSH/openssh-4.0p1/regress//t7.out > /dev/null
run test multiplex.sh ...
test connection multiplexing: envpass
test connection multiplexing: transfer
test connection multiplexing: status 0
test connection multiplexing: status 1
test connection multiplexing: status 4
test connection multiplexing: status 5
test connection multiplexing: status 44
Master running (pid=24948)
Exit request sent.
ok connection multiplexing
gmake[1]: Leaving directory `/tech_svc/SSH/openssh-4.0p1/regress'


> guyverdh at mchsi.com wrote:
> > It appears to be the ls.copy file creation that's failing...
> [...]
> > scp: failed copy /bin/ls
> > cmp: cannot open /tech_svc/SSH/openssh-4.0p1/regress/ls.copy
> > scp: corrupted copy of /bin/ls
> 
> Ah, I'll bet that either scp is not in the server's $PATH, or that the 
> first one in the path is the SunSSH one.
> 
> -- 
> Darren Tucker (dtucker at zip.com.au)
> GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
>      Good judgement comes with experience. Unfortunately, the experience
> usually comes from bad judgement.