[PATCH] 64 bit clean compilation patches
Darren Tucker
dtucker at zip.com.au
Fri Nov 25 14:54:20 EST 2005
On Tue, Nov 22, 2005 at 10:34:52AM -0800, Shaw Vrana wrote:
> Also troublesome are the following 64-bit related compilation warnings
> in scp.c :
>
> scp.c:589: warning: comparison between signed and unsigned
> scp.c:596: warning: comparison between signed and unsigned
>
> The stat structure likes the off_t, otherwise size_t is used. I'm not
> sure what to do with these. Any suggestions for a portable change here?
It looks like most of that wants changing to size_t with a sanity check
when copying from the off_t in the stat buffer.
We're currently prepping for a release, and I think that kind of change
would be a bit too invasive to do right now.
> - (u_int64_t)off, len);
> + (unsigned long long)off, len);
I've just applied all of these. They'll be in tomorrow's snapshot,
if you could check that I got them all I would appreciate it.
Thanks.
--
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4 37C9 C982 80C7 8FF4 FA69
Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.
More information about the openssh-unix-dev
mailing list