Testing for the 4.4p1 release

[Peter Stuge]

On Wed, Aug 30, 2006 at 11:41:53PM +1000, Damien Miller wrote:
> actively test snapshots or CVS and report back to the mailing list.

CVS 060831 10:38 UTC+2

gcc version 4.1.1 (Gentoo 4.1.1), OpenSSL 0.9.7j

OpenSSH has been configured with the following options:
                     User binaries: /usr/local/bin
                   System binaries: /usr/local/sbin
               Configuration files: /usr/local/etc
                   Askpass program: /usr/local/libexec/ssh-askpass
                      Manual pages: /usr/local/share/man/manX
                          PID file: /var/run
  Privilege separation chroot path: /var/empty
            sshd default user PATH:
/usr/bin:/bin:/usr/sbin:/sbin:/usr/local/bin
                    Manpage format: doc
                       PAM support: no
                   OSF SIA support: no
                 KerberosV support: no
                   SELinux support: no
                 Smartcard support: no
                     S/KEY support: no
              TCP Wrappers support: no
              MD5 password support: no
                   libedit support: no
  Solaris process contract support: no
       IP address in $DISPLAY hack: no
           Translate v4 in v6 hack: yes
                  BSD Auth support: no
              Random number source: OpenSSL internal ONLY

              Host: i686-pc-linux-gnu
          Compiler: gcc
    Compiler flags: -g -O2 -Wall -Wpointer-arith -Wuninitialized
-Wsign-compare -Wno-pointer-sign -std=gnu99 
Preprocessor flags: 
      Linker flags: 
         Libraries:   -lresolv -lcrypto -lutil -lz -lnsl  -lcrypt

Builds with warnings:

servconf.c: In function 'process_server_config_line':
servconf.c:980: warning: dereferencing type-punned pointer will break
strict-aliasing rules
servconf.c:991: warning: dereferencing type-punned pointer will break
strict-aliasing rules

I don't know C well enough to say what the best solution to this is.

SyslogFacility and LogLevel are enums,
ServerOptions.log_facility and .log_level are defined as
SyslogFacility and LogLevel respectively. The above lines read
(int *) &options->log_facility and (int *) &options->log_level.


sftp.c: In function 'parse_dispatch_command':
sftp.c:1028: warning: 'n_arg' may be used uninitialized in this function
sftp.c:1027: warning: 'iflag' may be used uninitialized in this function
sftp.c:1027: warning: 'lflag' may be used uninitialized in this function
sftp.c:1027: warning: 'pflag' may be used uninitialized in this function

parse_args() sets these, but can return with error before doing so.
iflag is used to set err_abort=0 before the return code of
parse_args() is checked.
Attached patch initializes the above variables.

All tests ok.


//Peter
-------------- next part --------------
--- sftp.c.orig	2006-08-31 10:44:33.000000000 +0200
+++ sftp.c	2006-08-31 10:44:57.000000000 +0200
@@ -1024,8 +1024,8 @@
     int err_abort)
 {
 	char *path1, *path2, *tmp;
-	int pflag, lflag, iflag, cmdnum, i;
-	unsigned long n_arg;
+	int pflag = 0, lflag = 0, iflag = 0, cmdnum, i;
+	unsigned long n_arg = 0;
 	Attrib a, *aa;
 	char path_buf[MAXPATHLEN];
 	int err = 0;