OpenSSH_4.3p1 configure patch

[Darren Tucker]

On Mon, Feb 06, 2006 at 02:42:55PM +0100, Corinna Vinschen wrote:
> I just tested the below patch and it solves the problem for me.
> Since session_exit_message is only called from session_close_by_pid,
> the solution seems to be the correct one.
> 
> 
> --- session.c.ORIG	2006-02-06 13:50:21.788927500 +0100
> +++ session.c	2006-02-06 13:45:27.042081500 +0100
> @@ -2176,7 +2176,6 @@ session_exit_message(Session *s, int sta
>  
>  	/* disconnect channel */
>  	debug("session_exit_message: release channel %d", s->chanid);
> -	s->pid = 0;
>  
>  	/*
>  	 * Adjust cleanup callback attachment to send close messages when
> @@ -2238,6 +2237,7 @@ session_close_by_pid(pid_t pid, int stat
>  		session_exit_message(s, status);
>  	if (s->ttyfd != -1)
>  		session_pty_cleanup(s);
> +	s->pid = 0;
>  }

FWIW the s->pid bit was added in this change:

revision 1.308
date: 2005/11/05 03:52:51;  author: djm;  state: Exp;  lines: +23 -14
   - djm at cvs.openbsd.org 2005/10/10 10:23:08
     [channels.c channels.h clientloop.c serverloop.c session.c]
     fix regression I introduced in 4.2: X11 forwardings initiated after
     a session has exited (e.g. "(sleep 5; xterm) &") would not start.
     bz #1086 reported by t8m AT centrum.cz; ok markus@ dtucker@

Not sure what (if any) effect the diff would have on the case above.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.