OpenSSH_4.3p1 configure patch

Corinna Vinschen vinschen at redhat.com
Tue Feb 7 05:16:10 EST 2006


On Feb  7 01:06, Darren Tucker wrote:
> On Mon, Feb 06, 2006 at 02:42:55PM +0100, Corinna Vinschen wrote:
> > I just tested the below patch and it solves the problem for me.
> > Since session_exit_message is only called from session_close_by_pid,
> > the solution seems to be the correct one.
> > 
> > 
> > --- session.c.ORIG	2006-02-06 13:50:21.788927500 +0100
> > +++ session.c	2006-02-06 13:45:27.042081500 +0100
> > @@ -2176,7 +2176,6 @@ session_exit_message(Session *s, int sta
> >  
> >  	/* disconnect channel */
> >  	debug("session_exit_message: release channel %d", s->chanid);
> > -	s->pid = 0;
> >  
> >  	/*
> >  	 * Adjust cleanup callback attachment to send close messages when
> > @@ -2238,6 +2237,7 @@ session_close_by_pid(pid_t pid, int stat
> >  		session_exit_message(s, status);
> >  	if (s->ttyfd != -1)
> >  		session_pty_cleanup(s);
> > +	s->pid = 0;
> >  }
> 
> FWIW the s->pid bit was added in this change:

I found another problem.  If I switch on privilege separation on
Cygwin, I get two syslog messages per login, one from the privsep
process and another one from the child sshd which handles the connection.

This is only a headsup so far, it's too late for today to debug this.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat




More information about the openssh-unix-dev mailing list