[openssh-unix-dev] Testing for the 4.4p1 release

[Darren Tucker]

On Fri, Sep 01, 2006 at 08:14:51PM -0500, David Bronder wrote:
> Damien Miller wrote:
> > 
> > The 4.4p1 release is approaching now, so we are now asking people to 
> > actively test snapshots or CVS and report back to the mailing list.
> 
> [AIX 5.1 ML5, IBM VAC 6 compiler, openssh-SNAP-20060902]

Thanks for testing.

> Fails to build.  See below for details.  Same result with a stripped
> down configure line (just adding --with-zlib=/usr/local).
[...]
>           Compiler: cc -qlanglvl=ansi

I noticed that in your other report in which it worked, you had "cc
-qlanglvl=extc89" instead.  Does this make a difference to the TAILQ_HEAD
error below?  (It appears that this line of the code has not changed
for years.)

> "/usr/include/usersec.h", line 625.32: 1506-310 (I) The type "struct aud_rec" was introduced in a parameter list, and will go out of scope at the end of the function declaration or definition.

The patch below should fix those.

[...]
> "packet.c", line 162.12: 1506-010 (E) Macro TAILQ_HEAD invoked with a null argument for parameter name.

Please see my query above about compiler flags.

> "/usr/include/paths.h", line 50.9: 1506-213 (S) Macro name _PATH_BSHELL cannot be redefined.
> "/usr/include/paths.h", line 50.9: 1506-358 (I) "_PATH_BSHELL" is defined on line 322 of defines.h.

Hmm, the "cannot be redefined" sounds like we need to fix those before the
release.


Index: openbsd-compat/port-aix.h
===================================================================
RCS file: /usr/local/src/security/openssh/cvs/openssh_cvs/openbsd-compat/port-aix.h,v
retrieving revision 1.26
diff -u -p -r1.26 port-aix.h
--- openbsd-compat/port-aix.h	28 May 2005 10:28:40 -0000	1.26
+++ openbsd-compat/port-aix.h	2 Sep 2006 03:13:36 -0000
@@ -38,7 +38,7 @@
 #ifdef WITH_AIXAUTHENTICATE
 # include <login.h>
 # include <userpw.h>
-# if defined(HAVE_SYS_AUDIT_H) && defined(AIX_LOGINFAILED_4ARG)
+# if defined(HAVE_SYS_AUDIT_H)
 #  include <sys/audit.h>
 # endif
 # include <usersec.h>

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.