OpenSSH 5.1: call for testing

[Corinna Vinschen]

On Jul  9 00:18, Damien Miller wrote:
> On Mon, 7 Jul 2008, Corinna Vinschen wrote:
> 
> > Other than that:
> > 
> > - session.c, line 427:
> > 
> >     #define USE_PIPES
> > 
> >   Is that planned or just left over fomr some test?
> 
> No, that is planned. We now unconditionally use pipes for communicating
> with the session subprocesses because they seem to give better semantics
> for half-closed channels (cf. https://bugzilla.mindrot.org/b/85).

Ok.  Given that USE_PIPES is now only used in sftp.c, wouldn't it 
be easier now to always use pipes, even in sftp.c?  That would drop
the whole test and a bunch of conditional code.

> > - The following testcases fail on Cygwin 1.5.25:
> > 
> >   - addrmatch.sh  tries to run IPv6 tests even though IPv6 is not
> >                   available.
> 
> I'm not sure of a good way to determine at runtime whether IPv6 is
> available on a platform. Perhaps these tests should be disabled in
> portable or made non-fatal.

Ack.  Unfortunately `ssh -6' falls silently back to IPv4 instead of
complaining on platforms not supporting IPv6.  Complaining would allow
to use this as a test.


Corinna

-- 
Corinna Vinschen
Cygwin Project Co-Leader
Red Hat