Testing wanted: OpenSSH 4.8

[Damien Miller]

On Sat, 15 Mar 2008, Jan-Frode Myklebust wrote:

> On 2008-03-14, Damien Miller <djm at mindrot.org> wrote:
> >> 
> >> It seems to require:
> >> 
> >> 	UsePrivilegeSeparation no
> >
> > No, it should not and does not on the platforms I have tested on. What
> > errors do you see when privsep is enabled?
> >
> 
> On RHEL3u2 using sftp client version OpenSSH_3.6.1p2:

This should fix it (already committed):

Index: ChangeLog
===================================================================
RCS file: /var/cvs/openssh/ChangeLog,v
retrieving revision 1.4878
diff -u -p -r1.4878 ChangeLog
--- ChangeLog	14 Mar 2008 22:25:54 -0000	1.4878
+++ ChangeLog	15 Mar 2008 06:27:53 -0000
@@ -3,6 +3,8 @@
    empty; report and patch from Peter Stuge
  - (djm) [regress/test-exec.sh] Silence noise from detection of putty
    commands; report from Peter Stuge
+ - (djm) [session.c] Relocate incorrectly-placed closefrom() that was causing
+   crashes when used with ChrootDirectory
 
 20080314
  - (tim) [regress/sftp-cmds.sh] s/cd/lcd/ in lls test. Reported by
Index: session.c
===================================================================
RCS file: /var/cvs/openssh/session.c,v
retrieving revision 1.363
diff -u -p -r1.363 session.c
--- session.c	11 Mar 2008 11:58:25 -0000	1.363
+++ session.c	15 Mar 2008 06:27:53 -0000
@@ -1328,8 +1328,6 @@ safely_chroot(const char *path, uid_t ui
 
 	}
 
-	closefrom(STDERR_FILENO + 1);
-
 	if (chdir(path) == -1)
 		fatal("Unable to chdir to chroot path \"%s\": "
 		    "%s", path, strerror(errno));
@@ -1658,6 +1656,8 @@ do_child(Session *s, const char *command
 			exit(1);
 #endif
 	}
+
+	closefrom(STDERR_FILENO + 1);
 
 	if (!options.use_login)
 		do_rc_files(s, shell);