Bug+bugfix in sftp-server : failed to rename file on sshfs mount

[Johan Kielbaey]

2008/11/5 Ben Lindstrom <mouring at eviladmin.org>:
> Without seeing the patch I can't judge it.
>
> However, why is sshfs failure to implement things right an OpenSSH bug?

Point taken. I guess I explained myself wrong. Obviously the fact that
sshfs doesn't implement the link() call is not an OpenSSH bug. From my
understanding the SFTPv3 protocol doesn't feature creation of hard
links.

sftp-server falls back to the rename() syscall if the link() syscall
fails with certain error codes. EOPNOTSUPP is such an errorcode. Sshfs
however returns ENOSYS, which is not such as errorcode.

Allowing a fall back to the rename() call upon ENOSYS errorcode,
solves the issue for all filesystem that don't implement hard links.

An alternative solution would be to give preference to the rename()
call over the link() call all the way. If you prefer I could work on a
patch for that.

>
> BTW you may want to file it with http://bugzilla.mindrot.org/  so it doesn't
> get lost as well (or at least skim the open and closed bugs on the rename()
> and link() discussions.
>

Done. Bug# 1535

Kind regards,
Johan