QoS marking for Openssh (review wanted)

Damien Miller djm at mindrot.org
Fri Feb 11 13:01:10 EST 2011


On Wed, 9 Feb 2011, Philip Prindeville wrote:

> This is very different from the defines of IPTOS_CLASS_CS0 ... IPTOS_CLASS_CS7
> which I had in my patch, and which I identified with the comment:
> 
> /*
>  * Temporarily needed file until glibc 2.12 becomes ubiquitous.
>  */
> 
> So the provenance of the names would be clear, and exactly what we
> were trying to match against.

I used the defines available on BSD systems instead of glibc's.

> Note also that the Class-Selectors predated the definition of
> Differentiated Services Code Points by several years, hence the
> different naming.
>
> I'll file a couple of bugs to fix this and another issue.

What is the issue you are talking about? That we internally use different
define names, or incorrect values?

-d


More information about the openssh-unix-dev mailing list