QoS marking for Openssh (review wanted)

[Philip Prindeville]

On 2/10/11 6:01 PM, Damien Miller wrote:
> On Wed, 9 Feb 2011, Philip Prindeville wrote:
>
>> This is very different from the defines of IPTOS_CLASS_CS0 ... IPTOS_CLASS_CS7
>> which I had in my patch, and which I identified with the comment:
>>
>> /*
>>   * Temporarily needed file until glibc 2.12 becomes ubiquitous.
>>   */
>>
>> So the provenance of the names would be clear, and exactly what we
>> were trying to match against.
> I used the defines available on BSD systems instead of glibc's.
>
>> Note also that the Class-Selectors predated the definition of
>> Differentiated Services Code Points by several years, hence the
>> different naming.
>>
>> I'll file a couple of bugs to fix this and another issue.
> What is the issue you are talking about? That we internally use different
> define names, or incorrect values?
>
> -d

Didn't have access to a BSD box at the time (it had a hard drive go bad), and didn't realize that BSD didn't use the same values as the glibc headers.  The values that you used are correct.

It's just a shame that there's a schism now between linux (and other platforms using glibc) and BSD.

The other issue is that you're still using 'lowdelay' and 'throughput' as the default values, which were obsoleted in 1998...

-Philip