autoconf.ac [was Re: Call for testing: OpenSSH-5.7]

[Tim Rice]

On Sun, 16 Jan 2011, Tim Rice wrote:

> On Fri, 14 Jan 2011, Tim Rice wrote:
> 
> > I'll let Damien decide.
> 
> Now the diff is larger that the file. (configure.ac.gz attached)
> 
> Consistent M4 quoting throughout,
> updated obsolete AC_TRY_COMPILE with AC_COMPILE_IFELSE,
> updated obsolete AC_TRY_LINK with AC_LINK_IFELSE,
> updated obsolete AC_TRY_RUN with AC_RUN_IFELSE,
> misc white space changes for consistency/readability.
> I left the obsolete AC_TRY_LINK_FUNC for now.
> 
> There is probably more that could be done but I only did things
> that I had a high comfort level putting into 5.7.
> 
> Rather than reviewing 4000+ lines of diff, it is simpler see if config.h
> comes out the same. The steps are comething like this

Did anyone spot the mistakes?

After a break, I reliazed the thing to do is diff the 2 generated cofigure
files. It made it easy to spot these.
.........
--- ../openssh/configure.ac.new	2011-01-16 20:36:34.995637068 -0800
+++ configure.ac.corrected	2011-01-16 21:35:30.576837070 -0800
@@ -171,7 +171,7 @@
 		AC_LINK_IFELSE(
 			[AC_LANG_PROGRAM([[ #include <stdio.h> ]],
 			[[
-	char x[[256]]; snprintf(x, sizeof(x), "XXX"); return 0;
+	char x[256]; snprintf(x, sizeof(x), "XXX"); return 0;
 			 ]])],
 		    [ AC_MSG_RESULT([yes])
 		      CFLAGS="$saved_CFLAGS $t"
@@ -180,7 +180,7 @@
 		      AC_RUN_IFELSE(
 			[AC_LANG_PROGRAM([[ #include <stdio.h> ]],
 			[[
-	char x[[256]]; snprintf(x, sizeof(x), "XXX"); return 0;
+	char x[256]; snprintf(x, sizeof(x), "XXX"); return 0;
 			]])],
 			[ AC_MSG_RESULT([yes])
 			  break ],
@@ -1243,7 +1245,7 @@
 #include <skey.h>
 				]], [[
 (void)skeychallenge(NULL,"name","",0);
-i				]])],
+				]])],
 			[
 				AC_MSG_RESULT([yes])
 				AC_DEFINE([SKEYCHALLENGE_4ARG], [1],
.........

-- 
Tim Rice				Multitalents	(707) 887-1469
tim at multitalents.net