Potential memory leak in sshd [detected by melton]

[Zhenbo Xu]

2012/2/6 Ángel González <keisial at gmail.com>

>  On 04/02/12 02:55, Zhenbo Xu wrote:
>
> The url below is the index of bug reports that are checked as real
> bugs manually.
> http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/sshd/index.html
>
>
> Shall we fix these bugs? Or just let them go since they are not so serious?
>
> Hope for your replies!
>
>  The 10th report is another false positive:
>   Logic error Memory leak auth-options.i 10587 28 View Report<http://lcs.ios.ac.cn/%7Exuzb/bugsfound/memleak/openssh-5.9p1/realbugs/sshd/report-mVEeJj.html#EndPath>
> http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/sshd/report-mVEeJj.html#EndPath
>
> Melton complains that in line 10587 the memory of data wasn't released,
> but there's a call to buffer_free(&data);
> in line 10585.
>
>
What melton complains is the heap object returned by
buffer_get_cstring_ret<http://lcs.ios.ac.cn/~xuzb/bugsfound/memleak/openssh-5.9p1/realbugs/sshd/linked_files/linked-TOML0p.html#Path29_2>
wasn't
released.




-- 
Zhenbo Xu