Portablility patch for openssh 6.0p1 configure.ac

Pieter Bowman bowman at math.utah.edu
Fri May 4 04:08:35 EST 2012


>> ...
>> Pieter Bowman <bowman at math.utah.edu> writes:
>> > --- configure.ac.orig	2012-04-19 05:46:38.000000000 -0600
>> > +++ configure.ac	2012-05-03 08:25:49.429260884 -0600
>> > @@ -3236,6 +3236,7 @@
>> >  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
>> >  #include <sys/types.h>
>> >  #include <sys/stat.h>
>> > +#include <sys/param.h>
>> >  #ifdef HAVE_SYS_TIME_H
>> >  # include <sys/time.h>
>> >  #endif
>> 
>> <sys/param.h> includes <sys/types.h> and should always be included
>> before any other headers.
>> ...

You are probably correct.  However, after examining the full source of
OpenSSH, I find that in most cases <sys/types.h> precedes
<sys/param.h>.  I could generate patches to "fix" all instances, but
that might be better for one of the OpenSSH developers to handle.

Pieter


More information about the openssh-unix-dev mailing list