Portablility patch for openssh 6.0p1 configure.ac

[Darren Tucker]

On Thu, May 03, 2012 at 07:17:09PM +0200, Dag-Erling Smørgrav wrote:
> Pieter Bowman <bowman at math.utah.edu> writes:
> > --- configure.ac.orig	2012-04-19 05:46:38.000000000 -0600
> > +++ configure.ac	2012-05-03 08:25:49.429260884 -0600
> > @@ -3236,6 +3236,7 @@
> >  AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[
> >  #include <sys/types.h>
> >  #include <sys/stat.h>
> > +#include <sys/param.h>
> >  #ifdef HAVE_SYS_TIME_H
> >  # include <sys/time.h>
> >  #endif
> 
> <sys/param.h> includes <sys/types.h> and should always be included
> before any other headers.

Indeed, the OpenBSD style guide says to include only one of these two as
the first include.  That said, doing includes portably is a massive
headache, so actually doing this in all the source files is likely to
break something somewhere.

Anyway, I've committed a change of sys/types.h to sys/params.h for just
this test (similar to a couple of other tests in configure) which should
resolve the problem.

-- 
Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.