[patch] Update bsd-cygwin_util files (was Re: Announce: OpenSSH 6.2 released)

Darren Tucker dtucker at zip.com.au
Mon Apr 1 12:41:59 EST 2013

On Wed, Mar 27, 2013 at 03:14:18PM +0100, Corinna Vinschen wrote:
> On second thought (and after some sleep), this is probably not the right
> thing to do.  Changing the type for UINT64 in the Windows headers just
> because of a single instance of clashing definitions in a POSIX file is
> pretty intrusive.  The potential side effects of this change are simply
> not worth it.
> As a result I have now reworked the bsd-cygwin_util.* files in
> openbsd-compat.  The most important change is not to include the
> windows.h header at all.  The only two Windows definitions used are
> HANDLE and INVALID_HANDLE_VALUE.  I defined those in bsd-cygwin_util.h
> so there's no reason anymore to include windows headers.  This fixes
> the UINT64 issue as well, obviously.
> Additionally I made the handling of open vs. binary_open a bit more
> clear (I think) by introducing a NO_BINARY_OPEN definition.
> Is that ok to apply?

applied, thanks.

Darren Tucker (dtucker at zip.com.au)
GPG key 8FF4FA69 / D9A3 86E9 7EEE AF4B B2D4  37C9 C982 80C7 8FF4 FA69
    Good judgement comes with experience. Unfortunately, the experience
usually comes from bad judgement.

More information about the openssh-unix-dev mailing list