Call for testing: OpenSSH-6.2

[Peter Stuge]

Damien Miller wrote:
> $ ./configure && make tests

Warnings on Gentoo Linux x86_64 gcc-4.7.2 in 20130228 snapshot build:

krl.c: In function 'choose_next_state':
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 5 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 7 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 8 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 9 has type 'u_int64_t' [-Wformat]
krl.c:507:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 10 has type 'u_int64_t' [-Wformat]
krl.c: In function 'revoked_certs_generate':
krl.c:542:7: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 3 has type 'u_int64_t' [-Wformat]
krl.c:542:7: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 4 has type 'u_int64_t' [-Wformat]
krl.c: In function 'ssh_krl_from_blob':
krl.c:932:6: warning: format '%llu' expects argument of type 'long long unsigned int', but argument 2 has type 'u_int64_t' [-Wformat]

This one for every single file:

<command-line>:0:0: warning: "_FORTIFY_SOURCE" redefined [enabled by default]
bsd-arc4random.c:1:0: note: this is the location of the previous definition

Additionally, during plain make:

auth2-chall.c: In function 'auth2_challenge_start':
auth2-chall.c:172:22: warning: array subscript is above array bounds [-Warray-bounds]

line 64: KbdintDevice *devices[] = {
line 172: for (i = 0; devices[i]; i++)


This from make tests:

regress/modpipe.c: In function 'parse_modification':
regress/modpipe.c:81:6: warning: format '%lli' expects argument of
type 'long long int *', but argument 4 has type 'u_int64_t *' [-Wformat]


And a failed test, run as regular user:

run test agent.sh ...
Permission denied.
agent fwd proto 1 failed (exit code 0)
Permission denied (publickey,password,keyboard-interactive).
agent fwd proto 2 failed (exit code 0)
failed simple agent test
make[1]: *** [t-exec] Error 1

I ran make clean, make, and make tests separately, the test fails
again, though slightly less verbosely:

run test agent.sh ...
Permission denied.
Permission denied (publickey,password,keyboard-interactive).
make[1]: *** [t-exec] Error 1

Running the test manually with -x as such:

cd regress && \
export TEST_SHELL=sh && \
export TEST_ENV=MALLOC_OPTIONS=AFGJPRX && \
export TEST_SSH_SSH=/tmp/openssh/ssh && \
export TEST_SSH_SSHD=/tmp/openssh/sshd && \
export TEST_SSH_SSHADD=/tmp/openssh/ssh-add && \
export TEST_SSH_SSHAGENT=/tmp/openssh/ssh-agent && \
sh -x $(pwd)/test-exec.sh $(pwd) $(pwd)/agent.sh

Gives:

++ trace 'agent forwarding'
++ echo 'trace: agent forwarding'
++ '[' X = Xyes ']'
++ for p in 1 2
++ /tmp/openssh/ssh -A -1 -F /tmp/openssh/regress/ssh_proxy somehost ssh-add -l
++ '[' 0 -ne 0 ']'
++ /tmp/openssh/ssh -A -1 -F /tmp/openssh/regress/ssh_proxy somehost '/tmp/openssh/ssh -1 -F /tmp/openssh/regress/ssh_proxy somehost exit 51'
Permission denied.
++ '[' 255 -ne 51 ']'
++ fail 'agent fwd proto 1 failed (exit code 0)'
++ echo 'FAIL: agent fwd proto 1 failed (exit code 0)'
++ RESULT=1
++ echo 'agent fwd proto 1 failed (exit code 0)'
agent fwd proto 1 failed (exit code 0)
++ for p in 1 2
++ /tmp/openssh/ssh -A -2 -F /tmp/openssh/regress/ssh_proxy somehost ssh-add -l
++ '[' 0 -ne 0 ']'
++ /tmp/openssh/ssh -A -2 -F /tmp/openssh/regress/ssh_proxy somehost '/tmp/openssh/ssh -2 -F /tmp/openssh/regress/ssh_proxy somehost exit 52'
Permission denied (publickey,password,keyboard-interactive).
++ '[' 255 -ne 52 ']'
++ fail 'agent fwd proto 2 failed (exit code 0)'
++ echo 'FAIL: agent fwd proto 2 failed (exit code 0)'
++ RESULT=1
++ echo 'agent fwd proto 2 failed (exit code 0)'
agent fwd proto 2 failed (exit code 0)

Running:

$ unset SSH_AGENT_PID SSH_AUTH_SOCK

makes no difference.


//Peter