Call for testing: OpenSSH-6.5

[Tom G. Christensen]

On 27/01/14 14:36, Tom G. Christensen wrote:
> So this is the real problem:
> checking for inttypes.h... no
> ...
> checking for uintXX_t types in inttypes.h... yes
> ...
>
> It should not be looking for uintXX_t in inttypes.h if the header is
> unuseable (ie. ac_cv_header_inttypes_h=no).
>
Patch attached.
It will avoid the extra testing for types in headers we already know are 
not available.
This follows the style already found in configure.ac.

It fixes the build on IRIX 5.3 when using the SGI compiler, and a quick 
test on CentOS 6.5 verifies that it makes no difference there.

> Also even if inttypes.h is available and defines uintXX_t, the source does not seem to make consistent use of it (only used in roaming_*.c).

This part I've not touched.
There is some inconsistence in the use of <stdint.h> and <inttypes.h>.
In includes.h <stdint.h> is always included if HAVE_STDINT_H is true, in 
which case it makes no sense that poly1305.c also includes it.
The roaming_c*.c files check for HAVE_INTTYPES_H and includes it if 
available, but relies on includes.h otherwise.

Should includes.h simply check HAVE_INTTYPES_H? perhaps only if 
HAVE_STDINT_H is not defined?

-tgc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-configure.ac-only-look-for-types-in-useable-headers.patch
Type: text/x-patch
Size: 1573 bytes
Desc: not available
URL: <http://lists.mindrot.org/pipermail/openssh-unix-dev/attachments/20140129/d2a321d8/attachment-0001.bin>