scp doesn't work with large (>2GB) files

[Theo de Raadt]

> Part of the reason it was done this way is to help transition from the
> old 32bit off_t to a 64bit off_t and to provide access to largefiles
> from 32bit applications.

Still, it is ridiculous.  It is a strong reversal from the unification
efforts of POSIX.

Sun should have looked at kernel-supported emulation environments for
better handling of this.

Doing so has worked VERY WELL for us.

> Passing O_LARGEFILE to open(2) without any other changes is the wrong
> way to do it and may cause problems with code that doesn't check all
> return values for functions that manipulate files and file offsets.

OK.  So people are saying that patch is bogus.  Not surprising, I
suppose: Markus gets mailed lots of bogus patches.